Messages in this thread | | | Date | Fri, 26 Jun 2020 15:43:44 +0200 | From | Greg KH <> | Subject | Re: [PATCH RFC 2/5] usb:cdns3: Add pci to platform driver wrapper |
| |
On Fri, Jun 26, 2020 at 06:54:47AM +0200, Pawel Laszczak wrote: > Patch adds PCI specific glue driver that creates and registers in-system > cdns-usbssp platform device.
Ick, no.
Platform devices are ONLY to be used for when you have a real platform device. If your device is a PCI device, use that. Don't try to be cute and make a platform device when you don't have one please.
> Thanks to that we will be able to use > the cdns-usbssp platform driver for USBSS-DEV controller > build on PCI board.
No, fix up that driver to not care about it being a platform device, make it just accept any type of 'struct device'.
thanks,
greg k-h
| |