Messages in this thread | | | Date | Fri, 26 Jun 2020 13:27:13 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH 6/9] sysctl: Call sysctl_head_finish on error |
| |
On Fri, Jun 26, 2020 at 12:17:01PM +0000, Luis Chamberlain wrote: > On Fri, Jun 26, 2020 at 09:58:33AM +0200, Christoph Hellwig wrote: > > From: "Matthew Wilcox (Oracle)" <willy@infradead.org> > > > > This error path returned directly instead of calling sysctl_head_finish(). > > And if the commit log can say why this was bad. Found through code > inspection from what I recall right?
I don't know why it's bad, it's just different from every other exit path from this function, and it's user-triggerable, so it just needs to get fixed.
| |