Messages in this thread | | | Date | Fri, 26 Jun 2020 11:44:50 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH v4 12/12] x86/traps: Fix up invalid PASID |
| |
On Thu, Jun 25, 2020 at 01:17:22PM -0700, Fenghua Yu wrote:
> +static bool fixup_pasid_exception(void) > +{ > + if (!IS_ENABLED(CONFIG_INTEL_IOMMU_SVM)) > + return false; > + if (!static_cpu_has(X86_FEATURE_ENQCMD)) > + return false;
elsewhere you had another variation:
+ if (!IS_ENABLED(CONFIG_INTEL_IOMMU_SVM)) + return; + + if (!cpu_feature_enabled(X86_FEATURE_ENQCMD)) + return;
Which is it, and why do we need the CONFIG thing when combined with the enabled thing?
| |