Messages in this thread | | | Date | Thu, 25 Jun 2020 16:00:37 -0700 (PDT) | Subject | Re: [PATCH v2 2/2] net: macb: free resources on failure path of at91ether_open() | From | David Miller <> |
| |
From: Claudiu Beznea <claudiu.beznea@microchip.com> Date: Wed, 24 Jun 2020 13:08:18 +0300
> DMA buffers were not freed on failure path of at91ether_open(). > Along with changes for freeing the DMA buffers the enable/disable > interrupt instructions were moved to at91ether_start()/at91ether_stop() > functions and the operations on at91ether_stop() were done in > their reverse order (compared with how is done in at91ether_start()): > before this patch the operation order on interface open path > was as follows: > 1/ alloc DMA buffers > 2/ enable tx, rx > 3/ enable interrupts > and the order on interface close path was as follows: > 1/ disable tx, rx > 2/ disable interrupts > 3/ free dma buffers. > > Fixes: 7897b071ac3b ("net: macb: convert to phylink") > Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Also applied and queued up for -stable.
Please submit a proper header posting "[PATCH 0/N] " in the future when you submit a patch series. Thank you.
| |