Messages in this thread | | | Subject | Re: [PATCH 2/2] staging: qlge: fix else after return or break | From | Joe Perches <> | Date | Thu, 25 Jun 2020 15:13:14 -0700 |
| |
On Fri, 2020-06-26 at 05:57 +0800, Coiby Xu wrote: > Remove unnecessary elses after return or break.
unrelated trivia:
> diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c [] > @@ -1391,12 +1391,11 @@ static void ql_dump_cam_entries(struct ql_adapter *qdev) > pr_err("%s: Failed read of mac index register\n", > __func__); > return; > - } else { > - if (value[0]) > - pr_err("%s: CAM index %d CAM Lookup Lower = 0x%.08x:%.08x, Output = 0x%.08x\n", > - qdev->ndev->name, i, value[1], value[0], > - value[2]);
looks like all of these could use netdev_err
netdev_err(qdev, "etc...", i, value[1], value[0], value[2]);
etc...
| |