Messages in this thread | | | Date | Thu, 25 Jun 2020 16:40:29 -0400 | From | Bruce Fields <> | Subject | Re: [PATCH v2] SUNRPC: Add missing definition of ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE |
| |
On Mon, Jun 15, 2020 at 08:33:40AM -0400, Chuck Lever wrote: > > > > On Jun 15, 2020, at 2:25 AM, Christophe Leroy <christophe.leroy@csgroup.eu> wrote: > > > > Even if that's only a warning, not including asm/cacheflush.h > > leads to svc_flush_bvec() being empty allthough powerpc defines > > ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE. > > > > CC net/sunrpc/svcsock.o > > net/sunrpc/svcsock.c:227:5: warning: "ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE" is not defined [-Wundef] > > #if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE > > ^ > > > > Include linux/highmem.h so that asm/cacheflush.h will be included. > > > > Reported-by: Christophe Leroy <christophe.leroy@csgroup.eu> > > Reported-by: kernel test robot <lkp@intel.com> > > Cc: Chuck Lever <chuck.lever@oracle.com> > > Fixes: ca07eda33e01 ("SUNRPC: Refactor svc_recvfrom()") > > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> > > LGTM. > > Acked-by: Chuck Lever <chuck.lever@oracle.com>
Thanks, applying for 5.8.--b.
| |