Messages in this thread | | | Subject | Re: [PATCH v4 01/18] nitro_enclaves: Add ioctl interface definition | From | "Paraschiv, Andra-Irina" <> | Date | Thu, 25 Jun 2020 20:42:57 +0300 |
| |
On 25/06/2020 16:29, Stefan Hajnoczi wrote: > On Wed, Jun 24, 2020 at 05:02:54PM +0300, Paraschiv, Andra-Irina wrote: >> On 23/06/2020 11:56, Stefan Hajnoczi wrote: >>> On Mon, Jun 22, 2020 at 11:03:12PM +0300, Andra Paraschiv wrote: >>>> +/* User memory region flags */ >>>> + >>>> +/* Memory region for enclave general usage. */ >>>> +#define NE_DEFAULT_MEMORY_REGION (0x00) >>>> + >>>> +/* Memory region to be set for an enclave (write). */ >>>> +struct ne_user_memory_region { >>>> + /** >>>> + * Flags to determine the usage for the memory region (write). >>>> + */ >>>> + __u64 flags; >>> Where is the write flag defined? >>> >>> I guess it's supposed to be: >>> >>> #define NE_USER_MEMORY_REGION_FLAG_WRITE (0x01) >> For now, the flags field is included in the NE ioctl interface for >> extensions, it is not part of the NE PCI device interface yet. > ... >> Ah, and just as a note, that "read" / "write" in parentheses means that a >> certain data structure / field is read / written by user space. I updated to >> use "in" / "out" instead of "read" / "write" in v5. > Oops, I got confused. I thought "(write)" was an example of a flag that > can be set on the memory region. Now I realize "write" means this field > is an input to the ioctl. :) > > Thanks for updating the docs.
I was thinking this may be the case. :) Should be less confusing now, with the "in / out" updates.
Thanks also for feedback.
Andra
Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.
| |