Messages in this thread | | | Subject | Re: [EXT] [PATCH v1] bnx2x: use generic power management | From | Igor Russkikh <> | Date | Thu, 25 Jun 2020 19:46:21 +0300 |
| |
On 24/06/2020 8:51 pm, Vaibhav Gupta wrote: > External Email > > ---------------------------------------------------------------------- > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. > > After upgrading to the generic structure, PCI core will take care of > required tasks and drivers should do only device-specific operations. > > The driver was also calling bnx2x_set_power_state() to set the power state > of the device by changing the device's registers' value. It is no more > needed. > > Compile-tested only. > > Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com> > --- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 15 ++++++--------- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h | 4 +--- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 +-- > 3 files changed, 8 insertions(+), 14 deletions(-)
Acked-by: Igor Russkikh <irusskikh@marvell.com>
Sudarsana, could you please give it a short sanity test and report back?
Thanks, Igor
| |