Messages in this thread | | | Date | Thu, 25 Jun 2020 17:25:23 +0200 | From | Petr Mladek <> | Subject | Re: record_printk_text tricks: was: [PATCH v3 3/3] printk: use the lockless ringbuffer |
| |
On Thu 2020-06-25 14:09:46, Petr Mladek wrote: > On Thu 2020-06-18 16:55:19, John Ogness wrote: > > Replace the existing ringbuffer usage and implementation with > > lockless ringbuffer usage. Even though the new ringbuffer does not > > require locking, all existing locking is left in place. Therefore, > > this change is purely replacing the underlining ringbuffer. > > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > +static size_t record_print_text(struct printk_record *r, bool syslog, > > + bool time)
[...]
> > +static size_t get_record_text_size(struct printk_info *info, > > + unsigned int line_count, > > + bool syslog, bool time) > > +{
Nit: This should get called get_record_print_text_size(). It will make it more clear that it counts the prefixes added for printing.
Best Regards, Petr
PS: I have finished review of this 3rd patch. I am going to look at the 2nd patch the following week if I find the courage ;-)
| |