lkml.org 
[lkml]   [2020]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] clocksource: Ingenic: Add support for the Ingenic X1000 OST.
Hi "周琰杰,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tip/timers/core]
[cannot apply to daniel.lezcano/clockevents/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Zhou-Yanjie/Add-support-for-the-OST-in-Ingenic-X1000/20200625-005621
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 809eb4e9bf9d84eb5b703358afd0d564d514f6d2
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/clocksource/ingenic-sysost.c: In function 'ingenic_ost_cevt_set_next':
>> drivers/clocksource/ingenic-sysost.c:221:9: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551614' to '4294967294' [-Woverflow]
221 | writel(~OSTFR_FFLAG, ost->base + OST_REG_OSTFR);
drivers/clocksource/ingenic-sysost.c:225:9: warning: conversion from 'long unsigned int' to 'unsigned int' changes value from '18446744073709551614' to '4294967294' [-Woverflow]
225 | writel(~OSTMR_FMASK, ost->base + OST_REG_OSTMR);
drivers/clocksource/ingenic-sysost.c: In function 'ingenic_ost_init':
drivers/clocksource/ingenic-sysost.c:477:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
477 | if (ret)
| ^

vim +221 drivers/clocksource/ingenic-sysost.c

215
216 static int ingenic_ost_cevt_set_next(unsigned long next,
217 struct clock_event_device *evt)
218 {
219 struct ingenic_ost *ost = to_ingenic_ost(evt);
220
> 221 writel(~OSTFR_FFLAG, ost->base + OST_REG_OSTFR);
222 writel(next, ost->base + OST_REG_OST1DFR);
223 writel(OSTCR_OST1CLR, ost->base + OST_REG_OSTCR);
224 writel(OSTESR_OST1ENS, ost->base + OST_REG_OSTESR);
225 writel(~OSTMR_FMASK, ost->base + OST_REG_OSTMR);
226
227 return 0;
228 }
229

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2020-06-25 11:31    [W:0.055 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site