Messages in this thread | | | Date | Thu, 25 Jun 2020 12:04:49 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] intel_idle: Fix uninitialized variable bug |
| |
On Wed, Jun 24, 2020 at 03:41:05PM +0200, Rafael J. Wysocki wrote: > On Wed, Jun 24, 2020 at 3:19 PM Dan Carpenter <dan.carpenter@oracle.com> wrote: > > > > The "tick" variable isn't initialized if "lapic_timer_always_reliable" > > is true. > > If lapic_timer_always_reliable is true, then > static_cpu_has(X86_FEATURE_ARAT) must also be true AFAICS. > > So the lapic_timer_always_reliable check in there looks redundant.
Can the lapic_timer_always_reliable variable just be removed entirely and replaced with an static_cpu_has(X86_FEATURE_ARAT) check?
regards, dan carpenter
| |