Messages in this thread | | | Subject | Re: cocci script from 2016 - assignment in if ? | From | Joe Perches <> | Date | Thu, 25 Jun 2020 00:49:10 -0700 |
| |
On Thu, 2020-06-25 at 08:49 +0200, Julia Lawall wrote: > > On Wed, 24 Jun 2020, joe@perches.com wrote: > > > https://lore.kernel.org/patchwork/patch/649705/ > > > > Any particular reason this wasn't applied? > > > > I ask because I added something similar recently to checkpatch. > > It probably slipped through the cracks at the time the Coccinelle > scripts maintainer disappeared. I can check and see if it does anything > more than your script.
The checkpatch thing only works on single lines, so this cocci script looks more whitespace robust but this script doesn't appear to handle code like
if (!(foo = bar(...))) baz;
where the checkpatch thing converts it OK.
| |