| Date | Wed, 24 Jun 2020 17:37:13 +0200 (CEST) | From | Miroslav Benes <> | Subject | Re: [RFC][PATCH v5 01/51] objtool: Factor out reasons to build objtool |
| |
Hi,
this is a nice improvement.
> diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile > index 7770edcda3a0..aa0c6d3d2d46 100644 > --- a/tools/objtool/Makefile > +++ b/tools/objtool/Makefile > @@ -1,6 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > include ../scripts/Makefile.include > include ../scripts/Makefile.arch > +include $(OUTPUT)/../../include/config/auto.conf > > # always use the host compiler > ifneq ($(LLVM),) > @@ -47,8 +48,8 @@ CFLAGS += $(if $(elfshdr),,-DLIBELF_USE_DEPRECATED) > > AWK = awk > > -SUBCMD_CHECK := n > -SUBCMD_ORC := n > +SUBCMD_CHECK := $(CONFIG_OBJTOOL_SUBCMD_CHECK) > +SUBCMD_ORC := $(CONFIG_OBJTOOL_SUBCMD_ORC) > > ifeq ($(SRCARCH),x86) > SUBCMD_CHECK := y
I guess you can remove ifeq for x86 in this patch, right? You do it later in 3/51, but it seems to belong here.
Miroslav
|