Messages in this thread | | | Subject | Re: [PATCH v2] media: venus: core: Fix runtime PM imbalance in venus_probe | From | Markus Elfring <> | Date | Wed, 24 Jun 2020 17:25:17 +0200 |
| |
I propose to combine two tags in the previous patch subject.
> pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. For other error > paths after this call, things are the same.
How do you think about a wording variant like the following?
Change description: The PM runtime usage counter is incremented even if a call of the function “pm_runtime_get_sync” failed. Thus decrement it also in error cases so that the reference counting is kept consistent.
Add also a call of the function “pm_runtime_get_noresume” in one if branch for the completion of the desired exception handling.
Would you like to add the tag “Fixes” to the commit message?
Regards, Markus
| |