Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Wed, 24 Jun 2020 15:51:39 +0200 | Subject | Re: [PATCH 04/22] gpiolib: cdev: refactor gpiohandle_flags_to_desc_flags |
| |
wt., 23 cze 2020 o 06:02 Kent Gibson <warthog618@gmail.com> napisał(a): > > Refactor the mapping from handle flags to desc flags into a helper > function. > > The assign_bit is overkill where it is replacing the set_bit cases, as is > rechecking bits known to be clear in some circumstances, but the DRY > simplification more than makes up for any performance degradation, > especially as this is not a hot path. > > Signed-off-by: Kent Gibson <warthog618@gmail.com> >
Agreed and I like the code shrink.
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
| |