lkml.org 
[lkml]   [2020]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 04/22] gpiolib: cdev: refactor gpiohandle_flags_to_desc_flags
    wt., 23 cze 2020 o 06:02 Kent Gibson <warthog618@gmail.com> napisał(a):
    >
    > Refactor the mapping from handle flags to desc flags into a helper
    > function.
    >
    > The assign_bit is overkill where it is replacing the set_bit cases, as is
    > rechecking bits known to be clear in some circumstances, but the DRY
    > simplification more than makes up for any performance degradation,
    > especially as this is not a hot path.
    >
    > Signed-off-by: Kent Gibson <warthog618@gmail.com>
    >

    Agreed and I like the code shrink.

    Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

    \
     
     \ /
      Last update: 2020-06-24 15:52    [W:3.837 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site