lkml.org 
[lkml]   [2020]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] firmware: imx: Move i.MX SCU soc driver into SCU firmware driver
Date
Hi, Franck/Arnd

> Subject: RE: [PATCH] firmware: imx: Move i.MX SCU soc driver into SCU
> firmware driver
>
> Hello,
>
> The move of folder is a good idea however I do not feel adding the code of
> soc-imx-scu.c to imx-scu.c is the best.
> Until now imx-scu.c was focused on exchanging the RPC and init the IRQ.
> Why not have soc-imx-scu.c copied to imx-scu-soc.c (change filename) to
> have a pattern similar to imx-scu-irq? And keep the imx_scu_soc_init into
> imx-scu.c.
>
Sound like making sense to me, it can make the code architecture more clear.

Hi, Arnd
What do you think?

Thanks,
Anson

\
 
 \ /
  Last update: 2020-06-24 15:16    [W:0.091 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site