lkml.org 
[lkml]   [2020]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: Looping more in detach_tasks() when RT and CFS tasks are present
Hi Pavan,

On Wed, 24 Jun 2020 at 13:42, Pavan Kondeti <pkondeti@codeaurora.org> wrote:
>
> Hi Vincent/Peter,
>
> in load_balance(), we derive env->loop_max based on rq->nr_running.
> When the busiest rq has both RT and CFS tasks, we do more loops in
> detach_tasks(). Is there any reason for not using
> rq->cfs.h_nr_running?

Using cfs.h_nr_running seems fine for loop_max

>
> Lei Wen attempted to fix this before.
> https://lore.kernel.org/lkml/1376814322-7320-2-git-send-email-leiwen@marvell.com/

The 1st part of the patch is wrong because even if h_nr_running == 1
but nr_running > 1, we can pull the cfs thread without using active
balance

>
> Thanks,
> Pavan
>
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
> Linux Foundation Collaborative Project

\
 
 \ /
  Last update: 2020-06-24 14:41    [W:0.041 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site