Messages in this thread | | | Date | Wed, 24 Jun 2020 00:29:27 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH v2 06/12] arm64: dts: qcom: msm8994: Add SCM node |
| |
On Tue 23 Jun 16:30 PDT 2020, Konrad Dybcio wrote:
> >Shouldn't this be "qcom,scm-msm8992", "qcom,scm" ? > > > >(Or rather "qcom,scm-msm8994", "qcom,scm") > > Some DTs only have the SoC-specific one, and some also > have the generic one. But I can add the generic one if > you wish. > > I went with 8992, as I added it in the 8992 series > (gonna update that one soon, too, so we can get it merged) > and I didn't want to needlessly duplicate it. Ideally maybe we > could switch to just qcom,scm for clockless SCM compats? >
It's fairly common practice to specify both a specific and a generic compatible, this would allow us to in the driver do special handling of the specific in the future if we need to - without having to update the devicetree.
Regards, Bjorn
| |