Messages in this thread | | | Date | Wed, 24 Jun 2020 00:25:09 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v3 09/10] kallsyms: Hide layout |
| |
On Tue, Jun 23, 2020 at 10:23:26AM -0700, Kristen Carlson Accardi wrote: > +static int kallsyms_open(struct inode *inode, struct file *file) > +{ > + int ret; > + struct list_head *list; > + > + list = __seq_open_private(file, &kallsyms_sorted_op, sizeof(*list)); > + if (!list) > + return -ENOMEM; > + > + INIT_LIST_HEAD(list); > + > + ret = kallsyms_on_each_symbol(get_all_symbol_name, list); > + if (ret != 0) > + return ret; > + > + list_sort(NULL, list, kallsyms_list_cmp); > + > + return 0; > +}
Oh, wait, one thing! I think this feedback to v2 got missed: https://lore.kernel.org/lkml/202005211441.F63205B7@keescook/
This bug still exists, and has the same solution.
-- Kees Cook
| |