Messages in this thread | | | Date | Wed, 24 Jun 2020 00:11:21 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v3 08/10] x86: Add support for function granular KASLR |
| |
On Tue, Jun 23, 2020 at 10:23:25AM -0700, Kristen Carlson Accardi wrote: > This commit contains the changes required to re-layout the kernel text > sections generated by -ffunction-sections shortly after decompression. > Documentation of the feature is also added. > [...] > Signed-off-by: Kristen Carlson Accardi <kristen@linux.intel.com> > Reviewed-by: Tony Luck <tony.luck@intel.com> > Tested-by: Tony Luck <tony.luck@intel.com>
This looks good! I wonder about some way (in the future) to share the sorting routines for kallsyms, exceptions, orc, etc. For now, though, I think this is fine.
> [...] > + if (cmdline_find_option("fgkaslr", arg, sizeof(arg)) == 3 && > + !strncmp(arg, "off", 3)) { > + warn("FG_KASLR disabled on cmdline."); > + nofgkaslr = 1; > + }
I was recently reminded by Randy Lunlap to document my new boot params, so I need to point out the same here. :) With a section added to Documentation/admin-guide/kernel-parameters.txt consider this:
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |