Messages in this thread | | | Subject | Re: [PATCH v3 3/8] mm/hugetlb: unify migration callbacks | From | Mike Kravetz <> | Date | Wed, 24 Jun 2020 14:18:46 -0700 |
| |
On 6/22/20 11:13 PM, js1304@gmail.com wrote: > From: Joonsoo Kim <iamjoonsoo.kim@lge.com> > > There is no difference between two migration callback functions, > alloc_huge_page_node() and alloc_huge_page_nodemask(), except > __GFP_THISNODE handling. This patch adds an argument, gfp_mask, on > alloc_huge_page_nodemask() and replace the callsite for > alloc_huge_page_node() with the call to > alloc_huge_page_nodemask(..., __GFP_THISNODE). > > It's safe to remove a node id check in alloc_huge_page_node() since > there is no caller passing NUMA_NO_NODE as a node id. > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Thanks for consolidating these.
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- Mike Kravetz
| |