lkml.org 
[lkml]   [2020]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sctp: Don't advertise IPv4 addresses if ipv6only is set on the socket
On Tue, Jun 23, 2020 at 11:04:17AM -0500, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> If a socket was set ipv6only, it would still send IPv4 addresses in the
> init and init ack packets. So don't add IPv4 addresses to ipv6only
> sockets.
>
> Based on a patch by Xin Long <lucien.xin@gmail.com>
>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> ---
> I have tested this and it seem to fix the issue. However, I'm wondering
> if it might be better to fix it where the addresses are put into the
> association as opposed to where they are put into the message.

Yes, it is. It even highlights why this issue was there in the first
place. Sending a patch right after this email.

Marcelo

\
 
 \ /
  Last update: 2020-06-24 22:32    [W:0.137 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site