lkml.org 
[lkml]   [2020]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] mm/page_alloc: fix documentation error and remove magic numbers
On Wed, Jun 24, 2020 at 12:49:43PM -0400, Joel Savitz wrote:
> When I increased the upper bound of the min_free_kbytes value in
> ee8eb9a5fe863, I forgot to tweak the above comment to reflect
> the new value. This patch fixes that mistake.
>
> In addition, this patch replaces the magic number bounds with symbolic
> constants to clarify the logic.
>
> changes from v1:
> - declare constants via enum instead of separate integers
>
> Suggested-by: John Hubbard <jhubbard@nvidia.com>
> Suggested-by: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Joel Savitz <jsavitz@redhat.com>

NAK. Just fix the documentation. It's bad form to combine two completely
different things in one patch anyway.

\
 
 \ /
  Last update: 2020-06-24 19:02    [W:0.100 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site