Messages in this thread | | | Date | Wed, 24 Jun 2020 18:01:31 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH v2] mm/page_alloc: fix documentation error and remove magic numbers |
| |
On Wed, Jun 24, 2020 at 12:49:43PM -0400, Joel Savitz wrote: > When I increased the upper bound of the min_free_kbytes value in > ee8eb9a5fe863, I forgot to tweak the above comment to reflect > the new value. This patch fixes that mistake. > > In addition, this patch replaces the magic number bounds with symbolic > constants to clarify the logic. > > changes from v1: > - declare constants via enum instead of separate integers > > Suggested-by: John Hubbard <jhubbard@nvidia.com> > Suggested-by: Vlastimil Babka <vbabka@suse.cz> > Signed-off-by: Joel Savitz <jsavitz@redhat.com>
NAK. Just fix the documentation. It's bad form to combine two completely different things in one patch anyway.
| |