lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] tools/thermal: tmon: include pthread and time headers in tmon.h
Date
> -----Original Message-----
> From: Florian Fainelli <f.fainelli@gmail.com>
> Sent: Thursday, June 18, 2020 8:23 AM
> To: Markus Mayer <markus.mayer@broadcom.com>; Daniel Lezcano
> <daniel.lezcano@linaro.org>; Pawnikar, Sumeet R
> <sumeet.r.pawnikar@intel.com>; Zhang, Rui <rui.zhang@intel.com>; Brian
> Norris <computersforpeace@gmail.com>
> Cc: Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>; Linux
> Kernel Mailing List <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH] tools/thermal: tmon: include pthread and time headers
> in tmon.h
>
>
>
> On 6/17/2020 4:58 PM, Markus Mayer wrote:
> > Include sys/time.h and pthread.h in tmon.h, so that types
> > "pthread_mutex_t" and "struct timeval tv" are known when tmon.h
> > references them.
> >
> > Without these headers, compiling tmon against musl-libc will fail with
> > these errors:
> >
> > In file included from sysfs.c:31:0:
> > tmon.h:47:8: error: unknown type name 'pthread_mutex_t'
> > extern pthread_mutex_t input_lock;
> > ^~~~~~~~~~~~~~~
> > make[3]: *** [<builtin>: sysfs.o] Error 1
> > make[3]: *** Waiting for unfinished jobs....
> > In file included from tui.c:31:0:
> > tmon.h:54:17: error: field 'tv' has incomplete type
> > struct timeval tv;
> > ^~
> > make[3]: *** [<builtin>: tui.o] Error 1
> > make[2]: *** [Makefile:83: tmon] Error 2
> >
> > Signed-off-by: Markus Mayer <mmayer@broadcom.com>
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> --
> Florian

Reviewed-by: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>

Thanks,
Sumeet.
\
 
 \ /
  Last update: 2020-06-23 19:18    [W:0.052 / U:1.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site