lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] media: i2c: imx290: replace msleep(10) with usleep_range(10000, 11000)
From
Date
This patch should be applied on top of "[PATCH v5 00/10] Improvements to IMX290 CMOS driver" series.

Thanks,
Andrey

On 23.06.2020 19:52, Andrey Konovalov wrote:
> This fixes checkpatch warnings of "msleep < 20ms can sleep for up to 20ms".
>
> Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
> ---
> drivers/media/i2c/imx290.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index 9c97830164e9..adcddf3204f7 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -406,7 +406,7 @@ static int imx290_set_register_array(struct imx290 *imx290,
> }
>
> /* Provide 10ms settle time */
> - msleep(10);
> + usleep_range(10000, 11000);
>
> return 0;
> }
> @@ -484,14 +484,14 @@ static int imx290_set_ctrl(struct v4l2_ctrl *ctrl)
> if (ctrl->val) {
> imx290_write_reg(imx290, IMX290_BLKLEVEL_LOW, 0x00);
> imx290_write_reg(imx290, IMX290_BLKLEVEL_HIGH, 0x00);
> - msleep(10);
> + usleep_range(10000, 11000);
> imx290_write_reg(imx290, IMX290_PGCTRL,
> (u8)(IMX290_PGCTRL_REGEN |
> IMX290_PGCTRL_THRU |
> IMX290_PGCTRL_MODE(ctrl->val)));
> } else {
> imx290_write_reg(imx290, IMX290_PGCTRL, 0x00);
> - msleep(10);
> + usleep_range(10000, 11000);
> if (imx290->bpp == 10)
> imx290_write_reg(imx290, IMX290_BLKLEVEL_LOW,
> 0x3c);
>

\
 
 \ /
  Last update: 2020-06-23 18:55    [W:0.033 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site