lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2]: arch: arm64: vdso: export the symbols for time()
On Mon, Jun 15, 2020 at 07:38:24AM -0700, Mark Salyzyn wrote:
> From: Chiawei Wang <chiaweiwang@google.com>
>
> __cvdso_time() can be found in vDSO implementation,
> but the symbols for time() are not exported.
>
> Export the symbols and run bionic-benchmarks.
>
> BEFORE:
> bionic-benchmarks32 --bionic_extra BM_time_time
> -----------------------------------------------------
> Benchmark Time CPU Iterations
> -----------------------------------------------------
> BM_time_time 83.6 ns 83.5 ns 8385964
>
> bionic-benchmarks64 --bionic_extra BM_time_time
> -----------------------------------------------------
> Benchmark Time CPU Iterations
> -----------------------------------------------------
> BM_time_time 63.5 ns 63.4 ns 11037509
>
> AFTER:
> bionic-benchmarks32 --bionic_extra BM_time_time
> -----------------------------------------------------
> Benchmark Time CPU Iterations
> -----------------------------------------------------
> BM_time_time 8.57 ns 8.56 ns 81887312
>
> bionic-benchmarks64 --bionic_extra BM_time_time
> -----------------------------------------------------
> Benchmark Time CPU Iterations
> -----------------------------------------------------
> BM_time_time 7.52 ns 7.51 ns 93253809
>
> Signed-off-by: Chiawei Wang <chiaweiwang@google.com>
> Signed-off-by: Mark Salyzyn <salyzyn@android.com>
> Cc: linux-kernel@vger.kernel.org
> Cc: kernel-team@android.com
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>
> Cc: Enrico Weigelt <info@metux.net>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Alexios Zavras <alexios.zavras@intel.com>
> Cc: linux-arm-kernel@lists.infradead.org

I don't understand this: neither arm nor arm64 offer the time() syscall
afaict, so the C library should be implementing it in terms of
clock_gettime() anyway, which _is_ implemented in the vDSO.

What's am I missing?

Will

\
 
 \ /
  Last update: 2020-06-23 16:46    [W:0.043 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site