Messages in this thread | | | From | Masahiro Yamada <> | Date | Tue, 23 Jun 2020 20:31:52 +0900 | Subject | Re: [PATCH] dt-bindings: bus: uniphier-system-bus: fix warning in example |
| |
On Tue, Jun 23, 2020 at 3:29 PM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > Since commit e69f5dc623f9 ("dt-bindings: serial: Convert 8250 to > json-schema"), the schema for "ns16550a" is checked. > > 'make dt_binding_check' emits the following warning: > > uart@5,00200000: $nodename:0: 'uart@5,00200000' does not match '^serial(@[0-9a-f,]+)*$' > > Rename the node to follow the pattern defined in > Documentation/devicetree/bindings/serial/serial.yaml > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > .../devicetree/bindings/bus/socionext,uniphier-system-bus.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml b/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml > index c4c9119e4a20..9fa4f891fa00 100644 > --- a/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml > +++ b/Documentation/devicetree/bindings/bus/socionext,uniphier-system-bus.yaml > @@ -87,7 +87,7 @@ examples: > phy-mode = "mii"; > }; > > - uart@5,00200000 { > + serial@5,00200000 {
I think '5,200000' is a better unit name.
Will send v2.
> compatible = "ns16550a"; > reg = <5 0x00200000 0x20>; > interrupts = <0 49 4>; > -- > 2.25.1 >
-- Best Regards Masahiro Yamada
| |