lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 14/15] net: phy: add PHY regulator support
    On Tue, Jun 23, 2020 at 11:41:11AM +0200, Bartosz Golaszewski wrote:
    > pon., 22 cze 2020 o 15:29 Russell King - ARM Linux admin
    > <linux@armlinux.org.uk> napisał(a):
    > >
    >
    > [snip!]
    >
    > >
    > > This is likely to cause issues for some PHY drivers. Note that we have
    > > some PHY drivers which register a temperature sensor in the probe
    > > function, which means they can be accessed independently of the lifetime
    > > of the PHY bound to the network driver (which may only be while the
    > > network device is "up".) We certainly do not want hwmon failing just
    > > because the network device is down.
    > >
    > > That's kind of worked around for the reset stuff, because there are two
    > > layers to that: the mdio device layer reset support which knows nothing
    > > of the PHY binding state to the network driver, and the phylib reset
    > > support, but it is not nice.
    > >
    >
    > Regulators are reference counted so if the hwmon driver enables it
    > using mdio_device_power_on() it will stay on even after the PHY driver
    > calls phy_device_power_off(), right? Am I missing something?

    If that is true, you will need to audit the PHY drivers to add that.

    --
    RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
    FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

    \
     
     \ /
      Last update: 2020-06-23 11:44    [W:2.484 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site