lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/2] ASoC: fsl_mqs: Don't check clock is NULL before calling clk API
From
Date
>     clk_prepare_enable and clk_disable_unprepare check the input
> clock parameter in the beginning of the function,

These functions call further functions which perform null pointer checks.


> if the parameter
> is NULL, clk_prepare_enable and clk_disable_unprepare will
> return immediately.

The interpretation of these function implementations seems to be reasonable.
Would you like to achieve any improvements for the corresponding software documentation?


> So Don't need to check input clock parameters before calling clk API.

What do you find imperative in this wording?

Another wording alternative:
Thus omit extra null pointer checks before four function calls.

Regards,
Markus

\
 
 \ /
  Last update: 2020-06-23 10:56    [W:0.327 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site