lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 084/206] tty: n_gsm: Fix SOF skipping
    Date
    From: Gregory CLEMENT <gregory.clement@bootlin.com>

    [ Upstream commit 84d6f81c1fb58b56eba81ff0a36cf31946064b40 ]

    For at least some modems like the TELIT LE910, skipping SOF makes
    transfers blocking indefinitely after a short amount of data
    transferred.

    Given the small improvement provided by skipping the SOF (just one
    byte on about 100 bytes), it seems better to completely remove this
    "feature" than make it optional.

    Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
    Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
    Link: https://lore.kernel.org/r/20200512115323.1447922-3-gregory.clement@bootlin.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/tty/n_gsm.c | 8 +-------
    1 file changed, 1 insertion(+), 7 deletions(-)

    diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
    index 86b7e20ffd7f1..8d8229dd27961 100644
    --- a/drivers/tty/n_gsm.c
    +++ b/drivers/tty/n_gsm.c
    @@ -669,7 +669,6 @@ static void gsm_data_kick(struct gsm_mux *gsm)
    {
    struct gsm_msg *msg, *nmsg;
    int len;
    - int skip_sof = 0;

    list_for_each_entry_safe(msg, nmsg, &gsm->tx_list, list) {
    if (gsm->constipated && msg->addr)
    @@ -691,15 +690,10 @@ static void gsm_data_kick(struct gsm_mux *gsm)
    print_hex_dump_bytes("gsm_data_kick: ",
    DUMP_PREFIX_OFFSET,
    gsm->txframe, len);
    -
    - if (gsm->output(gsm, gsm->txframe + skip_sof,
    - len - skip_sof) < 0)
    + if (gsm->output(gsm, gsm->txframe, len) < 0)
    break;
    /* FIXME: Can eliminate one SOF in many more cases */
    gsm->tx_bytes -= msg->len;
    - /* For a burst of frames skip the extra SOF within the
    - burst */
    - skip_sof = 1;

    list_del(&msg->list);
    kfree(msg);
    --
    2.25.1


    \
     
     \ /
      Last update: 2022-09-17 16:07    [W:2.994 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site