Messages in this thread | | | From | Andy Duan <> | Subject | RE: [EXT] Re: [PATCH v1] ARM: imx6plus: enable internal routing of clk_enet_ref where possible | Date | Wed, 24 Jun 2020 03:46:24 +0000 |
| |
From: Sven Van Asbroeck <thesven73@gmail.com> Sent: Wednesday, June 24, 2020 10:56 AM > Hi Andy, > > On Tue, Jun 23, 2020 at 9:40 PM Andy Duan <fugang.duan@nxp.com> wrote: > > > > The patch looks good. > > Reviewed-by: Fugang Duan <fugang.duan@nxp.com> > > Thank you ! > > To check we're on a plus, the patch uses: > cpu_is_imx6q() && imx_get_soc_revision() >= IMX_CHIP_REVISION_2_0 > > Fabio Estevam suggested that perhaps checking > of_machine_is_compatible("fsl,imx6qp") > might be preferable. What is your opinion on this?
Yes, I also think of_machine_is_compatible() is much better. Thanks.
| |