Messages in this thread | | | Subject | Re: [PATCH v6 1/5] KVM: s390: clean up redundant 'kvm_run' parameters | From | Tianjia Zhang <> | Date | Wed, 24 Jun 2020 10:39:39 +0800 |
| |
On 2020/6/23 23:31, Christian Borntraeger wrote: > > > On 23.06.20 15:14, Tianjia Zhang wrote: >> In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' >> structure. For historical reasons, many kvm-related function parameters >> retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This >> patch does a unified cleanup of these remaining redundant parameters. >> >> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> >> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com> >> --- >> arch/s390/kvm/kvm-s390.c | 23 +++++++++++++++-------- >> 1 file changed, 15 insertions(+), 8 deletions(-) > > Tinajia, > > I have trouble seeing value in this particular patch. We add LOCs > without providing any noticable benefit. All other patches in this series at > least reduce the amount of code. So I would defer this to Paolo if he prefers > to have this way across all architectures.
Yes, this is a full architecture optimization. Some of the architecture optimization has been merged into the mainline. I think it is necessary to unify this optimization. This is also the meaning of Paolo. You can refer to the email of the previous version: https://lkml.org/lkml/2020/4/27/16
Thanks, Tianjia
| |