Messages in this thread | | | Subject | Re: [PATCH 1/7] irqchip: Fix potential resource leaks | From | Tiezhu Yang <> | Date | Wed, 24 Jun 2020 09:44:51 +0800 |
| |
On 06/23/2020 11:55 PM, Markus Elfring wrote: >> There exists some potential resource leaks in the error path, fix them. > Will the tag “Fixes” become relevant for the commit message?
Hi Markus,
Thanks for your reply and suggestion.
This patch contains many files in drivers/irqchip, maybe I should split it into some small patches if use the tag "Fixes"?
> > > … >> +++ b/drivers/irqchip/irq-nvic.c >> @@ -94,6 +94,7 @@ static int __init nvic_of_init(struct device_node *node, >> >> if (!nvic_irq_domain) { >> pr_warn("Failed to allocate irq domain\n"); >> + iounmap(nvic_base); >> return -ENOMEM; >> } >> >> @@ -103,6 +104,7 @@ static int __init nvic_of_init(struct device_node *node, >> if (ret) { >> pr_warn("Failed to allocate irq chips\n"); >> irq_domain_remove(nvic_irq_domain); >> + iounmap(nvic_base); >> return ret; >> } > Can it helpful to add jump targets so that a bit of exception handling > can be better reused at the end of this function?
OK, no problem, I will do it in the v2.
By the way, I have resent this patch series due to git send-email failed, https://lore.kernel.org/patchwork/cover/1261517/
Thanks, Tiezhu
> > Regards, > Markus
| |