Messages in this thread Patch in this message | | | From | Gaurav Singh <> | Subject | [PATCH] [perf] lsdir_bid_tail_filter: fix index check | Date | Tue, 23 Jun 2020 21:35:22 -0400 |
| |
Check bounds before accessing d->d_name[].
Signed-off-by: Gaurav Singh <gaurav1086@gmail.com> --- tools/perf/util/build-id.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/build-id.c b/tools/perf/util/build-id.c index c076fc7fe025..8c35cbe93f10 100644 --- a/tools/perf/util/build-id.c +++ b/tools/perf/util/build-id.c @@ -431,7 +431,7 @@ static bool lsdir_bid_tail_filter(const char *name __maybe_unused, struct dirent *d) { int i = 0; - while (isxdigit(d->d_name[i]) && i < SBUILD_ID_SIZE - 3) + while (i < SBUILD_ID_SIZE - 3 && isxdigit(d->d_name[i])) i++; return (i == SBUILD_ID_SIZE - 3) && (d->d_name[i] == '\0'); } -- 2.17.1
| |