lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 101/477] xfs: Add the missed xfs_perag_put() for xfs_ifree_cluster()
    Date
    From: Chuhong Yuan <hslester96@gmail.com>

    [ Upstream commit 8cc0072469723459dc6bd7beff81b2b3149f4cf4 ]

    xfs_ifree_cluster() calls xfs_perag_get() at the beginning, but forgets to
    call xfs_perag_put() in one failed path.
    Add the missed function call to fix it.

    Fixes: ce92464c180b ("xfs: make xfs_trans_get_buf return an error code")
    Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
    Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/xfs/xfs_inode.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
    index d1772786af29d..8845faa8161a9 100644
    --- a/fs/xfs/xfs_inode.c
    +++ b/fs/xfs/xfs_inode.c
    @@ -2639,8 +2639,10 @@ xfs_ifree_cluster(
    error = xfs_trans_get_buf(tp, mp->m_ddev_targp, blkno,
    mp->m_bsize * igeo->blocks_per_cluster,
    XBF_UNMAPPED, &bp);
    - if (error)
    + if (error) {
    + xfs_perag_put(pag);
    return error;
    + }

    /*
    * This buffer may not have been correctly initialised as we
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 23:42    [W:4.024 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site