lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 315/477] pinctrl: imxl: Fix an error handling path in imx1_pinctrl_core_probe()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 9eb728321286c4b31e964d2377fca2368526d408 ]

    When 'pinctrl_register()' has been turned into 'devm_pinctrl_register()',
    an error handling path has not been updated.

    Axe a now unneeded 'pinctrl_unregister()'.

    Fixes: e55e025d1687 ("pinctrl: imxl: Use devm_pinctrl_register() for pinctrl registration")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Link: https://lore.kernel.org/r/20200530201952.585798-1-christophe.jaillet@wanadoo.fr
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/freescale/pinctrl-imx1-core.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/pinctrl/freescale/pinctrl-imx1-core.c b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
    index c00d0022d311b..421f7d1886e54 100644
    --- a/drivers/pinctrl/freescale/pinctrl-imx1-core.c
    +++ b/drivers/pinctrl/freescale/pinctrl-imx1-core.c
    @@ -638,7 +638,6 @@ int imx1_pinctrl_core_probe(struct platform_device *pdev,

    ret = of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
    if (ret) {
    - pinctrl_unregister(ipctl->pctl);
    dev_err(&pdev->dev, "Failed to populate subdevices\n");
    return ret;
    }
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 23:31    [W:2.204 / U:0.676 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site