| Date | Tue, 23 Jun 2020 23:11:03 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 4.19 066/206] soundwire: slave: dont init debugfs on device registration error |
| |
Hi!
> [ Upstream commit 8893ab5e8ee5d7c12e0fc1dca4a309475064473d ] > > The error handling flow seems incorrect, there is no reason to try and > add debugfs support if the device registration did not > succeed. Return on error.
> +++ b/drivers/soundwire/slave.c > @@ -55,6 +55,8 @@ static int sdw_slave_add(struct sdw_bus *bus, > list_del(&slave->node); > mutex_unlock(&bus->bus_lock); > put_device(&slave->dev); > + > + return ret; > } > > return ret;
Mainline is significantly different here; this patch does not make sense in v4.19 -- as it does not do anything.
Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] |