lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 106/206] usb: dwc2: gadget: move gadget resume after the core is in L0 state
    Date
    From: Fabrice Gasnier <fabrice.gasnier@st.com>

    [ Upstream commit 8c935deacebb8fac8f41378701eb79d12f3c2e2d ]

    When the remote wakeup interrupt is triggered, lx_state is resumed from L2
    to L0 state. But when the gadget resume is called, lx_state is still L2.
    This prevents the resume callback to queue any request. Any attempt
    to queue a request from resume callback will result in:
    - "submit request only in active state" debug message to be issued
    - dwc2_hsotg_ep_queue() returns -EAGAIN

    Call the gadget resume routine after the core is in L0 state.

    Fixes: f81f46e1f530 ("usb: dwc2: implement hibernation during bus suspend/resume")

    Acked-by: Minas Harutyunyan <hminas@synopsys.com>
    Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
    Signed-off-by: Felipe Balbi <balbi@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/dwc2/core_intr.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff --git a/drivers/usb/dwc2/core_intr.c b/drivers/usb/dwc2/core_intr.c
    index 19ae2595f1c3e..b23ce535c12e1 100644
    --- a/drivers/usb/dwc2/core_intr.c
    +++ b/drivers/usb/dwc2/core_intr.c
    @@ -421,10 +421,13 @@ static void dwc2_handle_wakeup_detected_intr(struct dwc2_hsotg *hsotg)
    if (ret && (ret != -ENOTSUPP))
    dev_err(hsotg->dev, "exit power_down failed\n");

    + /* Change to L0 state */
    + hsotg->lx_state = DWC2_L0;
    call_gadget(hsotg, resume);
    + } else {
    + /* Change to L0 state */
    + hsotg->lx_state = DWC2_L0;
    }
    - /* Change to L0 state */
    - hsotg->lx_state = DWC2_L0;
    } else {
    if (hsotg->params.power_down)
    return;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 23:04    [W:4.371 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site