lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 171/314] PCI: dwc: Fix inner MSI IRQ domain registration
    Date
    From: Marc Zyngier <maz@kernel.org>

    [ Upstream commit 0414b93e78d87ecc24ae1a7e61fe97deb29fa2f4 ]

    On a system that uses the internal DWC MSI widget, I get this
    warning from debugfs when CONFIG_GENERIC_IRQ_DEBUGFS is selected:

    debugfs: File ':soc:pcie@fc000000' in directory 'domains' already present!

    This is due to the fact that the DWC MSI code tries to register two
    IRQ domains for the same firmware node, without telling the low
    level code how to distinguish them (by setting a bus token). This
    further confuses debugfs which tries to create corresponding
    files for each domain.

    Fix it by tagging the inner domain as DOMAIN_BUS_NEXUS, which is
    the closest thing we have as to "generic MSI".

    Link: https://lore.kernel.org/r/20200501113921.366597-1-maz@kernel.org
    Signed-off-by: Marc Zyngier <maz@kernel.org>
    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Acked-by: Jingoo Han <jingoohan1@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pci/controller/dwc/pcie-designware-host.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
    index 8615f1548882a..fbcb211cceb43 100644
    --- a/drivers/pci/controller/dwc/pcie-designware-host.c
    +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
    @@ -263,6 +263,8 @@ int dw_pcie_allocate_domains(struct pcie_port *pp)
    return -ENOMEM;
    }

    + irq_domain_update_bus_token(pp->irq_domain, DOMAIN_BUS_NEXUS);
    +
    pp->msi_domain = pci_msi_create_irq_domain(fwnode,
    &dw_pcie_msi_domain_info,
    pp->irq_domain);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 22:40    [W:7.719 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site