lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 131/314] scsi: mpt3sas: Fix double free warnings
    Date
    From: Suganath Prabu S <suganath-prabu.subramani@broadcom.com>

    [ Upstream commit cbbfdb2a2416c9f0cde913cf09670097ac281282 ]

    Fix following warning from Smatch static analyser:

    drivers/scsi/mpt3sas/mpt3sas_base.c:5256 _base_allocate_memory_pools()
    warn: 'ioc->hpr_lookup' double freed

    drivers/scsi/mpt3sas/mpt3sas_base.c:5256 _base_allocate_memory_pools()
    warn: 'ioc->internal_lookup' double freed

    Link: https://lore.kernel.org/r/20200508110738.30732-1-suganath-prabu.subramani@broadcom.com
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Suganath Prabu S <suganath-prabu.subramani@broadcom.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/mpt3sas/mpt3sas_base.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
    index 752b71cfbe12c..7fd1d731555f9 100644
    --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
    +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
    @@ -4777,7 +4777,9 @@ _base_release_memory_pools(struct MPT3SAS_ADAPTER *ioc)
    }

    kfree(ioc->hpr_lookup);
    + ioc->hpr_lookup = NULL;
    kfree(ioc->internal_lookup);
    + ioc->internal_lookup = NULL;
    if (ioc->chain_lookup) {
    for (i = 0; i < ioc->scsiio_depth; i++) {
    for (j = ioc->chains_per_prp_buffer;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 22:28    [W:3.542 / U:0.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site