lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 154/314] drm/msm/mdp5: Fix mdp5_init error path for failed mdp5_kms allocation
    Date
    From: Roy Spliet <nouveau@spliet.org>

    [ Upstream commit e4337877c5d578722c0716f131fb774522013cf5 ]

    When allocation for mdp5_kms fails, calling mdp5_destroy() leads to undefined
    behaviour, likely a nullptr exception or use-after-free troubles.

    Signed-off-by: Roy Spliet <nouveau@spliet.org>
    Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
    index 91cd76a2bab11..77823ccdd0f8f 100644
    --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
    +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
    @@ -1037,7 +1037,8 @@ static int mdp5_init(struct platform_device *pdev, struct drm_device *dev)

    return 0;
    fail:
    - mdp5_destroy(pdev);
    + if (mdp5_kms)
    + mdp5_destroy(pdev);
    return ret;
    }

    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 22:28    [W:5.627 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site