lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 404/477] scsi: ufs-bsg: Fix runtime PM imbalance on error
    Date
    From: Dinghao Liu <dinghao.liu@zju.edu.cn>

    [ Upstream commit a1e17eb03e69bb61bd1b1a14610436b7b9be12d9 ]

    When ufs_bsg_alloc_desc_buffer() returns an error code, a pairing runtime
    PM usage counter decrement is needed to keep the counter balanced.

    Link: https://lore.kernel.org/r/20200522045932.31795-1-dinghao.liu@zju.edu.cn
    Fixes: 74e5e468b664 (scsi: ufs-bsg: Wake the device before sending raw upiu commands)
    Reviewed-by: Avri Altman <avri.altman@wdc.com>
    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/ufs/ufs_bsg.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/scsi/ufs/ufs_bsg.c b/drivers/scsi/ufs/ufs_bsg.c
    index 53dd87628cbe4..516a7f573942f 100644
    --- a/drivers/scsi/ufs/ufs_bsg.c
    +++ b/drivers/scsi/ufs/ufs_bsg.c
    @@ -106,8 +106,10 @@ static int ufs_bsg_request(struct bsg_job *job)
    desc_op = bsg_request->upiu_req.qr.opcode;
    ret = ufs_bsg_alloc_desc_buffer(hba, job, &desc_buff,
    &desc_len, desc_op);
    - if (ret)
    + if (ret) {
    + pm_runtime_put_sync(hba->dev);
    goto out;
    + }

    /* fall through */
    case UPIU_TRANSACTION_NOP_OUT:
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 22:19    [W:4.928 / U:0.684 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site