lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 386/477] perf parse-events: Fix an incompatible pointer
    Date
    From: Ian Rogers <irogers@google.com>

    [ Upstream commit c2412fae3f01725615b0de472095a9e16ed30ca9 ]

    Arrays are pointer types and don't need their address taking.

    Fixes: 8255718f4bed (perf pmu: Expand PMU events by prefix match)
    Signed-off-by: Ian Rogers <irogers@google.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lore.kernel.org/lkml/20200609053610.206588-1-irogers@google.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/perf/util/parse-events.y | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
    index 94f8bcd835826..9a41247c602ba 100644
    --- a/tools/perf/util/parse-events.y
    +++ b/tools/perf/util/parse-events.y
    @@ -348,7 +348,7 @@ PE_PMU_EVENT_PRE '-' PE_PMU_EVENT_SUF sep_dc
    struct list_head *list;
    char pmu_name[128];

    - snprintf(&pmu_name, 128, "%s-%s", $1, $3);
    + snprintf(pmu_name, sizeof(pmu_name), "%s-%s", $1, $3);
    free($1);
    free($3);
    if (parse_events_multi_pmu_add(_parse_state, pmu_name, &list) < 0)
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 22:17    [W:2.436 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site