lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 312/477] scsi: iscsi: Fix reference count leak in iscsi_boot_create_kobj
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit 0267ffce562c8bbf9b57ebe0e38445ad04972890 ]

    kobject_init_and_add() takes reference even when it fails. If this
    function returns an error, kobject_put() must be called to properly
    clean up the memory associated with the object.

    Link: https://lore.kernel.org/r/20200528201353.14849-1-wu000273@umn.edu
    Reviewed-by: Lee Duncan <lduncan@suse.com>
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/scsi/iscsi_boot_sysfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/iscsi_boot_sysfs.c b/drivers/scsi/iscsi_boot_sysfs.c
    index e4857b7280338..a64abe38db2d4 100644
    --- a/drivers/scsi/iscsi_boot_sysfs.c
    +++ b/drivers/scsi/iscsi_boot_sysfs.c
    @@ -352,7 +352,7 @@ iscsi_boot_create_kobj(struct iscsi_boot_kset *boot_kset,
    boot_kobj->kobj.kset = boot_kset->kset;
    if (kobject_init_and_add(&boot_kobj->kobj, &iscsi_boot_ktype,
    NULL, name, index)) {
    - kfree(boot_kobj);
    + kobject_put(&boot_kobj->kobj);
    return NULL;
    }
    boot_kobj->data = data;
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-06-23 22:14    [W:4.030 / U:0.696 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site