lkml.org 
[lkml]   [2020]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next v1 2/5] hinic: add support to set and get irq coalesce
From
Date
On 2020/6/23 6:07, Jakub Kicinski wrote:
> On Sat, 20 Jun 2020 17:42:55 +0800 Luo bin wrote:
>> @@ -1144,8 +1190,16 @@ static int nic_dev_init(struct pci_dev *pdev)
>> goto err_reg_netdev;
>> }
>>
>> + err = hinic_init_intr_coalesce(nic_dev);
>> + if (err) {
>> + netif_err(nic_dev, drv, netdev, "Failed to init_intr_coalesce\n");
>> + goto err_init_intr;
>> + }
>> +
>> return 0;
>>
>> +err_init_intr:
>> + unregister_netdev(netdev);
>> err_reg_netdev:
>> err_set_features:
>> hinic_hwdev_cb_unregister(nic_dev->hwdev,
>
> A little suspicious - you should finish all init before device is
> registered, once registered the interface can be immediately brought
> up.
> .
>
Will fix. Thanks for your review.

\
 
 \ /
  Last update: 2020-06-23 08:41    [W:0.053 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site