Messages in this thread | | | Subject | Re: [PATCH v2] nbd: Fix memory leak in nbd_add_socket | From | Markus Elfring <> | Date | Mon, 22 Jun 2020 09:52:22 +0200 |
| |
>> Can an other wording variant be nicer? > > em, how about this? > > > When adding first socket to nbd,
How do you think about to replace abbreviations by terms?
> if nsock's allocation fails,
… failed,
> config->socks is malloced
The data structure member “config->socks” was reallocated.
> but num_connections does not update,
But the data structure member “config->num_connections” was not updated.
> memory leak will occur(Function > nbd_config_put will only free config->socks when num_connections is not 0).
A memory leak will occur then because the function “nbd_config_put” will free “config->socks” only when “num_connections” is not zero.
Would you like to add an imperative wording to the commit message? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=625d3449788f85569096780592549d0340e9c0c7#n151
Regards, Markus
| |