lkml.org 
[lkml]   [2020]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 2/9] reset: Add Raspberry Pi 4 firmware reset controller
On Mon, Jun 22, 2020 at 5:26 PM Nicolas Saenz Julienne
<nsaenzjulienne@suse.de> wrote:
>
> Raspberry Pi 4's co-processor controls some of the board's HW
> initialization process, but it's up to Linux to trigger it when
> relevant. Introduce a reset controller capable of interfacing with
> RPi4's co-processor that models these firmware initialization routines as
> reset lines.

...

> + struct device_node *fw_node;

If you are going to use fwnode (as it should be), make sure the proper
data type is in use, i.e. struct fwnode_handle.

Otherwise, if you want to be OF centric (I discourage this, don't know
if RPi4 is ever going to run RHEL or other distros that require non-DT
firmwares), don't name fw_node. It's confusing.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-06-22 16:43    [W:0.478 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site