lkml.org 
[lkml]   [2020]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 10/11] arm64: dts: renesas: Add HiHope RZ/G2N Rev.3.0/4.0 sub board support
    Hi Prabhakar,

    On Sun, Jun 7, 2020 at 8:42 PM Lad Prabhakar
    <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
    > The HiHope RZ/G2N sub board sits below the HiHope RZ/G2N Rev.3.0/4.0 main
    > board.
    >
    > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    > Reviewed-by: Marian-Cristian Rotariu <marian-cristian.rotariu.rb@bp.renesas.com>

    One minor comment below.
    Apart from that:
    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

    > --- /dev/null
    > +++ b/arch/arm64/boot/dts/renesas/r8a774b1-hihope-rzg2n-ex.dts
    > @@ -0,0 +1,17 @@
    > +// SPDX-License-Identifier: GPL-2.0
    > +/*
    > + * Device Tree Source for the HiHope RZ/G2N Rev.3.0/4.0 connected to
    > + * sub board
    > + *
    > + * Copyright (C) 2020 Renesas Electronics Corp.
    > + */
    > +
    > +#include "r8a774b1-hihope-rzg2n.dts"
    > +#include "hihope-rzg2-ex.dtsi"
    > +
    > +/ {
    > + model = "HopeRun HiHope RZ/G2N with sub board";
    > + compatible = "hoperun,hihope-rzg2-ex", "hoperun,hihope-rzg2n",
    > + "renesas,r8a774b1";
    > +};
    > +

    "git am" tells me the there's a superfluous blank line at the end of the file.

    Gr{oetje,eeting}s,

    Geert


    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2020-06-22 14:53    [W:2.595 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site