Messages in this thread | | | Date | Mon, 22 Jun 2020 14:19:06 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [Cocci] [PATCH v3] coccinelle: misc: add array_size_dup script to detect missed overflow checks |
| |
On Mon, 22 Jun 2020, Denis Efremov wrote:
> What do you think about removing duplicates warning from the rule? > > I mean this kind of warnings: "WARNING: same array_size (line {p1[0].line})" > > As for now, I think it's better to not disturb developers with this kind > of things.
I agree. I guess there is a small overhead for the test, but if the code is not performance critical, being simpler is probably better.
julia
> > Thanks, > Denis > > >> +@as_dup@ > >> +expression subE1 <= as.E1; > >> +expression subE2 <= as.E2; > >> +expression as.E1, as.E2, E3; > >> +assignment operator aop; > >> +position p1, p2; > >> +@@ > >> + > >> +* array_size(E1, E2)@p1 > >> + ... when != \(E1\|E2\|subE1\|subE2\) aop E3 > >> + when != &\(E1\|E2\|subE1\|subE2\) > >> +* array_size(E1, E2)@p2 > >> + > >> +@script:python depends on report@ > >> +p1 << as_dup.p1; > >> +p2 << as_dup.p2; > >> +@@ > >> + > >> +coccilib.report.print_report(p2[0], > >> +f"WARNING: same array_size (line {p1[0].line})") > >> + > >> +@script:python depends on org@ > >> +p1 << as_dup.p1; > >> +p2 << as_dup.p2; > >> +@@ > >> + > >> +coccilib.org.print_todo(p2[0], > >> +f"WARNING: same array_size (line {p1[0].line})") > >> + > >
| |