lkml.org 
[lkml]   [2020]   [Jun]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error
On Sun, 21 Jun 2020 at 13:12, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Tue 16 Jun 23:56 PDT 2020, Naresh Kamboju wrote:
>
> > This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c
> >
> > Build error:
> > ../drivers/remoteproc/qcom_q6v5_mss.c:
> > In function ‘q6v5_mpss_init_image’:
> > ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:
> > error: implicit declaration of function ‘kfree’;
> > did you mean ‘vfree’? [-Werror=implicit-function-declaration]
> > 772 | kfree(metadata);
> > | ^~~~~
> > | vfree
> >
> > Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>
> Thanks for the patch Naresh, it looks correct but I've not seen this
> build error myself. Could you please let me know what you built to get
> this and if you have any suggestion on what caused it? (So we can add a
> Fixes: tag etc)

Thanks for the review.
This was an arm64 modules build failure on linux -next 20200616 tag.
This fix has already been taken care of by
Herbert Xu <herbert@gondor.apana.org.au> and got merged.
Fixes: f0187db056dc ("iov_iter: Move unnecessary inclusion of...")

ref:
https://lore.kernel.org/lkml/20200616010502.GA28834@gondor.apana.org.au/

- Naresh

\
 
 \ /
  Last update: 2020-06-22 08:19    [W:0.069 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site